[Theme] New theme: FomanticUI [beta]#2643
[Theme] New theme: FomanticUI [beta]#2643princerb wants to merge 45 commits intopallets-eco:masterfrom
Conversation
a5c1fbb to
39c3933
Compare
… f-theme-fomanticui
… f-theme-fomanticui
|
Due to the interconnection among all the template files, I was not committing the changes in order to keep the history organised. Hope today I will manage to push some completed code 🙂 |
… and update button classes
|
@princerb is this ready for review? |
Yes now, considering checklist items, but what's pushed should be solid for now. |
|
Would you be able to add an example that uses this theme to the repo, if you still have interest+capacity to pursue this? 🙏 |
ffaf65a to
dbc3be6
Compare
dde7b64 to
6e4e93f
Compare
|
Here you go https://github.com/princerb/flask-admin/tree/f-theme-fomanticui/examples/fomanticui |
|
As you may know, XEditable is no longer suppoerted since no one raise any PR for 10 yrs. If you are interested to fork this repo and enhance it, then I WILL work with you on that project. |
There are already many forks, and I do not think it's really necessary. Unless you really want to fork that, I would try to avoid reinventing the wheel.
Also, I think princerb already did most of the work. |
|
@princerb, i'm just offering my support to let this PR merged sooner |
|
That is a great job, thanx for your effort. However, we had a lot of merges to enhance the UX on Bootstrap4. could you please review those merges and make sure you have covered them as well in this PR?
|
|
hi, thanks for letting me know. Since I set this one as a beta theme, it would be safe to backlog those extra security fixes, but I'll take a look and also it would be so helpful if someone helps with it and review the PR as it's been here for so long and I basically forgot what I did here at that times)). (THere is an image u can pull and try this instantly btw) |
no problem , i think i can do those changes, could you please add me as a contributor in this repository so i can push the new changes? |
Isn't it easier to fork and PR his repo? |
| """Populate the database with a rich set of example data covering all models.""" | ||
| with app.app_context(): | ||
| db.create_all() | ||
| db.create_all() |
There was a problem hiding this comment.
| db.create_all() |
|
Can I try this without the docker image or is that a requirement? |
yes sure, but i thought i would be better if we keep moving on this exact branch. |


















A new theme - FomanticUI.
Quick try:
docker pull thomasstacey2/fa-fomantic:latest # remove "-p 6379:6379" if there is redis already running in port 6379 docker run -p 5000:5000 -p 6379:6379 thomasstacey2/fa-fomantic:latest🖼️ Previews
Checklist:
Other:
Backlogs: