Add Fedora CI opt-in/opt-out config options to packit-service.yaml#696
Open
m-blaha wants to merge 1 commit intopackit:mainfrom
Open
Add Fedora CI opt-in/opt-out config options to packit-service.yaml#696m-blaha wants to merge 1 commit intopackit:mainfrom
m-blaha wants to merge 1 commit intopackit:mainfrom
Conversation
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 37s |
lbarcziova
reviewed
Mar 18, 2026
Comment on lines
+139
to
+140
| # Used in opt-in mode (fedora_ci_run_by_default=false) | ||
| enabled_projects: [] |
Member
There was a problem hiding this comment.
maybe we can remove this to be explicit
Member
Author
There was a problem hiding this comment.
OK, I've removed it from production. I also added a comment for each option, just to clarify what they do. Wdyt?
Also clarifies the Fedora CI enabled_project comment. Since the Fedora CI is now on by default in production, the warning wording is a bit misleading.
m-blaha
force-pushed
the
eln-logdetective-opt-out
branch
from
132e708 to
a437877
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 36s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: packit/packit-service#3056