Skip to content

refactor: remove ID count from offsets - #478

Open
spacer07 wants to merge 2 commits into
ozontech:mainfrom
spacer07:409-remove-ids-count-from-offsets
Open

refactor: remove ID count from offsets#478
spacer07 wants to merge 2 commits into
ozontech:mainfrom
spacer07:409-remove-ids-count-from-offsets

Conversation

@spacer07

Copy link
Copy Markdown

Description

This completes the binary format cleanup started in #410. It:

  • bumps the fraction binary data version to V6;
  • stops writing the legacy ID count placeholder to the offsets section;
  • keeps V0–V5 fractions readable by skipping the legacy field for old versions;

Fixes #409


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.10%. Comparing base (3f9dedd) to head (1a5b840).

Files with missing lines Patch % Lines
frac/sealed_loader.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   71.07%   71.10%   +0.03%     
==========================================
  Files         232      232              
  Lines       18405    18404       -1     
==========================================
+ Hits        13082    13087       +5     
+ Misses       4342     4339       -3     
+ Partials      981      978       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkharms dkharms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cheb0 can you take a look as well, please?

LGTM :shipit:
Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not store count of ids in offsets section

3 participants