Change the format of fake PlatformIds - #111
Merged
Merged
Conversation
This makes explicit what the serials mean. Once this changes, there will need to be updates made to a4x2, voxel, and Omicron.
Collaborator
Author
|
This is required by https://github.com/oxidecomputer/voxel/pull/13 |
labbott
approved these changes
Jul 27, 2026
labbott
left a comment
labbott
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Is there any concern if we were to ever generate a real PlatformId that happens to match our fake one?
Collaborator
Author
I don't think so. This is just to ensure that we always use the fake one in our testbeds. Voxel was using two different ones in different places and this makes it clear that this should always be used. @sion42x and I discussed it with @rmustacc a week or so back and decided a consistently fake prefix would be best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes explicit what the serials mean.
Once this changes, there will need to be updates made to a4x2, voxel, and Omicron.