Switch the behavior of set_target_release to set_target_release_and_old_repo#9753
Merged
Switch the behavior of set_target_release to set_target_release_and_old_repo#9753
set_target_release to set_target_release_and_old_repo#9753Conversation
Contributor
Author
|
I ran into some confusing behavior with the measurement work without this change to |
labbott
force-pushed
the
labbott/reconfigurator_old_repo
branch
from
e1fed22 to
cc74a95
Compare
labbott
changed the title
set_target_release_and_old_repo in reconfigurator-cliset_target_release to set_target_release_and_old_repo
jgallagher
approved these changes
Jan 30, 2026
Collaborator
|
We discussed this on the update watercooler this morning and determined that this is probably fine. There could be value in a command that only updated the old or new repos to get the system into funky states, but the golden path function should do what it does on a real system. |
davepacheco
approved these changes
Jan 30, 2026
sunshowers
approved these changes
Jan 30, 2026
Previously, we had `set_target_release` and `set_target_release_and_old_repo` for reconfigurator-cli because there were concerns about the behavior of the system if the old repo was set during the middle of an update. This has since been fixed and the behavior of `set_target_release_and_old_repo` is what we should use everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting an old repo is the more accurate system behavior