Skip to content

Add measurements to blueprints #9718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labbott merged 7 commits into from
Feb 26, 2026
Merged

Add measurements to blueprints #9718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bca4d6d
Add measurement blueprints
labbott Feb 3, 2026
c2257b3
fixup tests
labbott Feb 24, 2026
0494af6
tweak that
labbott Feb 25, 2026
6bb566b
Drop unnecessary id and the extra default
labbott Feb 25, 2026
7d58610
Missed that
labbott Feb 25, 2026
d706b55
haha this is the correct database
labbott Feb 26, 2026
bfa3d73
TYPOS
labbott Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions dev-tools/omdb/tests/successes.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,6 +1612,13 @@ parent: <none>
B current contents


measurements:
------------------------------
hash version
------------------------------
install dataset (no version)


physical disks:
-----------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -1655,6 +1662,13 @@ parent: <none>
B current contents


measurements:
------------------------------
hash version
------------------------------
install dataset (no version)


physical disks:
----------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -1744,6 +1758,13 @@ parent: <none>
B current contents


measurements:
------------------------------
hash version
------------------------------
install dataset (no version)


physical disks:
-----------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -1787,6 +1808,13 @@ parent: <none>
B current contents


measurements:
------------------------------
hash version
------------------------------
install dataset (no version)


physical disks:
----------------------------------------------------------------
vendor model serial disposition
Expand Down
28 changes: 28 additions & 0 deletions dev-tools/reconfigurator-cli/tests/output/cmds-add-sled-no-disks-stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ parent: dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)
Copy link
Copy Markdown
Contributor

@jgallagher jgallagher Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only skimmed all these expectorate outputs, but just checking: it's expected that some will have unknown version and some will have no version?

Copy link
Copy Markdown
Contributor Author

@labbott labbott Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I forgot to update a few tests but install gets no version vs unknown version, I'll double check to make sure these are consistent



physical disks:
-------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -104,6 +111,13 @@ parent: dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -176,6 +190,13 @@ parent: dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -245,6 +266,13 @@ parent: dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down
14 changes: 14 additions & 0 deletions dev-tools/reconfigurator-cli/tests/output/cmds-add-zones-with-mupdate-override-stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@ to: blueprint 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1
sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6 (active, config generation 2 -> 3):
+ will remove mupdate override: (none) -> 2d0f6cbc-addc-47a2-962a-6a01e13376bf

measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -316,6 +323,13 @@ to: blueprint af934083-59b5-4bf6-8966-6fb5292c29e1

sled d81c6a84-79b8-4958-ae41-ea46c9b19763 (active, config generation 2 -> 3):

measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down
42 changes: 42 additions & 0 deletions dev-tools/reconfigurator-cli/tests/output/cmds-blueprint-history-stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ to: blueprint dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21

sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c (active, config generation 2):

measurements:
---------------------------
hash version
---------------------------
+ unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -196,6 +203,13 @@ to: blueprint dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21

sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6 (active, config generation 2):

measurements:
---------------------------
hash version
---------------------------
+ unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -316,6 +330,13 @@ to: blueprint dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21

sled d81c6a84-79b8-4958-ae41-ea46c9b19763 (active, config generation 2):

measurements:
---------------------------
hash version
---------------------------
+ unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -457,6 +478,13 @@ to: blueprint 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1

sled d81c6a84-79b8-4958-ae41-ea46c9b19763 (active, config generation 2 -> 3):

measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -601,6 +629,13 @@ to: blueprint 58d5e830-0884-47d8-a7cd-b2b3751adeb4

sled d81c6a84-79b8-4958-ae41-ea46c9b19763 (active, config generation 3 -> 4):

measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -763,6 +798,13 @@ to: blueprint df06bb57-ad42-4431-9206-abff322896c7

sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c (active, config generation 2 -> 3):

measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down
70 changes: 70 additions & 0 deletions dev-tools/reconfigurator-cli/tests/output/cmds-example-stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -224,6 +231,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -349,6 +363,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -553,6 +574,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -747,6 +775,13 @@ to: blueprint 86db3308-f817-4626-8838-4085949a6a41

sled 89d02b1b-478c-401a-8e28-7a26f74fa41b (active, config generation 2):

measurements:
---------------------------
hash version
---------------------------
+ unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -971,6 +1006,13 @@ to: blueprint 02697f74-b14a-4418-90f0-c28b2a3a6aa9

sled 89d02b1b-478c-401a-8e28-7a26f74fa41b (was active, config generation 2):

measurements:
---------------------------
hash version
---------------------------
- unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down Expand Up @@ -1221,6 +1263,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -1280,6 +1329,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -1339,6 +1395,13 @@ parent: 02697f74-b14a-4418-90f0-c28b2a3a6aa9
B current contents


measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


physical disks:
------------------------------------------------------------------------------------
vendor model serial disposition
Expand Down Expand Up @@ -2103,6 +2166,13 @@ to: blueprint 86db3308-f817-4626-8838-4085949a6a41

sled 32d8d836-4d8a-4e54-8fa9-f31d79c42646 (active -> decommissioned, config generation 2 -> 3):

measurements:
---------------------------
hash version
---------------------------
unknown (unknown version)


host phase 2 contents:
------------------------
slot boot image source
Expand Down
Loading
Loading