sled-agent: Remove direct dpd NAT entry creation in service zone startup path - #11073
Open
jgallagher wants to merge 3 commits into
Open
sled-agent: Remove direct dpd NAT entry creation in service zone startup path#11073jgallagher wants to merge 3 commits into
jgallagher wants to merge 3 commits into
Conversation
This is now handled by the dpd reconcilers running on each scrimlet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the scrimlet-reconcilers shipped in R22, it's safe to remove this code path: each scrimlet is responsible for configuring NAT entries for all service zones with its own switch zone's dpd, so the individual sled-agents starting service zones no longer need to. This is one of the main goals of #10167.
Closes #9727.
I'll re-test this on a racklette before merging, but it should be good to review - it's basically all deletions.