scrimlet-reconcilers: add uplinkd SMF reconciler#10686
Open
jgallagher wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is effectively moving code around from within sled-agent, but it's still part of the #10167 umbrella project:
sync_switch_configuration, in addition to talking to mgd/dpd, talks to sled-agent to trigger SMF property updates:omicron/nexus/src/app/background/tasks/sync_switch_configuration.rs
Lines 472 to 482 in 2340477
This PR adds a reconciler that updates the
uplinkdSMF properties. It usesscuffle, but should be consistent with the existing sled-agent implementation, although with many fewerzlogin oxz_switch svcprop ...since it talks directly to the SMF database in the zone.