You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't understand the check-opte-ver failure. I'm not sure what this PR changes that would affect it. I looked at other recent PR's and they don't seem to be running this check.
I tried changing deploy.sh to say target = "lab-opte-0.40" as the error suggests, but
check-out-ver still fails, with the confusing error message buildomat deploy job: lab-opte-0.40 (expected lab-opte-0.40), and
helios / deploy also fails, with Flagrant Error: Could not submit job: could not resolve target name "lab-opte-0.40".
This makes me wonder if the check might not be correct. It seems to be trying to check the 0.40, which does match, but perhaps it should be expecting the prefix to be lab-3.0-opte-.
I've got a PR close to done that updates crucible to 3c1708d86e10f0370807388a1efe092edd99d431 and propolis to 9343361f922d10c5825906a69c7bb05d139a3662, which should address a lot of the changes seen in this PR, and make the oximeter bump related diff much smaller. Sorry, I started it last week and then it was a week, I'm getting back to it today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: depends on oxidecomputer/crucible#1933, which must land first. If it's rebased, I'll need to update the git & sha hashes here.