Wait for all timeseries deletions to complete#10135
Open
Conversation
This is an attempt to address #10052, a flaky test deleting a timeseries by name. It's hard to generate a repro for that failure, since it relies on racing the deletion across all the ClickHouse nodes. But this should probably address it by ensuring we completely wait for the deletion to occur on all replicas before returning. This does make the query slower but (1) we don't run this today and (2) we definitely don't run multinode ClickHouse, which is the only place this would matter anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #10052, a flaky test deleting a timeseries by name. It's hard to generate a repro for that failure, since it relies on racing the deletion across all the ClickHouse nodes. But this should probably address it by ensuring we completely wait for the deletion to occur on all replicas before returning.
This does make the query slower but (1) we don't run this today and (2) we definitely don't run multinode ClickHouse, which is the only place this would matter anyway.