Use single execution_id for log and UpdateEngine.execution_id field#10120
Open
TimoFreiberg wants to merge 1 commit intooxidecomputer:mainfrom
Open
Use single execution_id for log and UpdateEngine.execution_id field#10120TimoFreiberg wants to merge 1 commit intooxidecomputer:mainfrom
TimoFreiberg wants to merge 1 commit intooxidecomputer:mainfrom
Conversation
Previously, one UUID was used for the slog field and another for the struct field, this seems likely to be a copy-paste error.
Contributor
|
Thanks. I actually fixed this when I extracted the update-engine into its own repo/crates.io: https://github.com/oxidecomputer/oxide-update-engine/blob/97343e5b7b03815a371e603e70f09196767a2efb/crates/oxide-update-engine/src/engine.rs#L96 #9936 moves omicron over to using oxide-update-engine from crates.io. I need to test it a bunch and then will land that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, one UUID was used for the slog field and another for the struct field, this seems likely to be a copy-paste error.