Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions cmd/manifest/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,14 @@ fn manifestcmd(context: &mut ExecutionContext) -> Result<()> {
}
}

const REFDES_HDR: &str = "REFDES";
const NO_REFDES: &str = "???";
let refdes_len = manifest
.fmt_meta
.max_refdes_len
.max(NO_REFDES.len())
.max(REFDES_HDR.len());

if !manifest.i2c_devices.is_empty() {
println!(
"{:>12} => {} device{}",
Expand All @@ -179,7 +187,7 @@ fn manifestcmd(context: &mut ExecutionContext) -> Result<()> {
);

println!(
"{:>19} {:2} {:2} {} {} {:13} {}",
"{:>19} {:2} {:2} {} {} {REFDES_HDR:refdes_len$} {:13} {}",
"ID", "C", "P", "MUX", "ADDR", "DEVICE", "DESCRIPTION"
);

Expand All @@ -191,12 +199,13 @@ fn manifestcmd(context: &mut ExecutionContext) -> Result<()> {
};

println!(
"{:>19} {:2} {:2} {:3} 0x{:02x} {:13} {}",
"{:>19} {:2} {:2} {:3} 0x{:02x} {:refdes_len$} {:13} {}",
ndx,
device.controller,
device.port.name,
mux,
device.address,
device.refdes.as_deref().unwrap_or(NO_REFDES),
device.device,
device.description
);
Expand Down Expand Up @@ -229,15 +238,19 @@ fn manifestcmd(context: &mut ExecutionContext) -> Result<()> {
manifest.sensors.len(),
if manifest.sensors.len() > 1 { "s" } else { "" }
);
println!("{:>19} {:23} {:11} {}", "ID", "NAME", "DEVICE", "KIND");
println!(
"{:>19} {:23} {:11} {REFDES_HDR:refdes_len$} {}",
"ID", "NAME", "DEVICE", "KIND"
);

for (ndx, s) in manifest.sensors.iter().enumerate() {
let device = match &s.device {
HubrisSensorDevice::I2c(ndx) => format!("i2c id={}", ndx),
HubrisSensorDevice::Other(dev, _) => dev.to_string(),
};
let refdes = s.refdes.as_deref().unwrap_or(NO_REFDES);
println!(
" {:3} {:23} {:11} {}",
" {:3} {:23} {:11} {refdes:refdes_len$} {}",
ndx, s.name, device, s.kind,
);
}
Expand Down
25 changes: 21 additions & 4 deletions cmd/validate/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,18 @@ struct ValidateArgs {
id: Option<usize>,
}

const REFDES_HDR: &str = "REFDES";
const NO_REFDES: &str = "???";

fn list(hubris: &HubrisArchive, hargs: &Option<I2cArgs>) -> Result<()> {
let refdes_len = hubris
.manifest
.fmt_meta
.max_refdes_len
.max(REFDES_HDR.len())
.max(NO_REFDES.len());
println!(
"{:2} {:>2} {:2} {:3} {:4} {:13} DESCRIPTION",
"{:2} {REFDES_HDR:refdes_len$} {:>2} {:2} {:3} {:4} {:13} DESCRIPTION",
"ID", "C", "P", "MUX", "ADDR", "DEVICE"
);

Expand All @@ -118,8 +127,9 @@ fn list(hubris: &HubrisArchive, hargs: &Option<I2cArgs>) -> Result<()> {
};

println!(
"{:2} {:2} {:2} {:3} 0x{:02x} {:13} {}",
"{:2} {:refdes_len$} {:2} {:2} {:3} 0x{:02x} {:13} {}",
ndx,
device.refdes.as_deref().unwrap_or(NO_REFDES),
device.controller,
device.port.name,
mux,
Expand All @@ -135,6 +145,12 @@ fn validate(context: &mut ExecutionContext) -> Result<()> {
let subargs = ValidateArgs::try_parse_from(&context.cli.cmd)?;
let hubris = &context.cli.archive()?;
let core = &mut *context.cli.attach_live_booted(hubris)?;
let refdes_len = hubris
.manifest
.fmt_meta
.max_refdes_len
.max(REFDES_HDR.len())
.max(NO_REFDES.len());

let hargs = if subargs.bus.is_some() || subargs.controller.is_some() {
Some(I2cArgs::parse(
Expand Down Expand Up @@ -195,7 +211,7 @@ fn validate(context: &mut ExecutionContext) -> Result<()> {
};

println!(
"{:2} {:11} {:>2} {:2} {:3} {:4} {:13} DESCRIPTION",
"{:2} {REFDES_HDR:refdes_len$} {:11} {:>2} {:2} {:3} {:4} {:13} DESCRIPTION",
"ID", "VALIDATION", "C", "P", "MUX", "ADDR", "DEVICE"
);

Expand Down Expand Up @@ -257,8 +273,9 @@ fn validate(context: &mut ExecutionContext) -> Result<()> {
};

println!(
"{:2} {:11} {:2} {:2} {:3} 0x{:02x} {:13} {}",
"{:2} {:refdes_len$} {:11} {:2} {:2} {:3} 0x{:02x} {:13} {}",
ndx,
device.refdes.as_deref().unwrap_or(NO_REFDES),
result,
device.controller,
device.port.name,
Expand Down

Large diffs are not rendered by default.

Loading
Loading