Remove call functionality from humility rpc#610
Conversation
cmd/rpc/src/lib.rs
Outdated
| //! ``` | ||
| //! | ||
| //! Alternatively, you can set the `HUMILITY_RPC_IP` environmental variable. | ||
| //! `humility rpc` lets you discover SPs on a network, instead of using a |
There was a problem hiding this comment.
So, I kinda feel like, if that's now the only thing it does, maybe it shouldn't be called humility rpc...maybe humility discover or something? It could remain aliased as humility rpc --listen for backwards compatibility if there's scripts that rely on this. It just seems a bit possibly confusing for the help command to be like "hey look! It's humility rpc, a command which doesn't actually perform RPCs!"
There was a problem hiding this comment.
Seems reasonable, I've renamed to humility discover (and added support for running without an archive).
| //! | ||
| //! `humility discover` lets you discover SPs on a network, instead of using a | ||
| //! physically attached debugger. Once SPs are discovered, they may be used as | ||
| //! a target by setting `HUMILITY_IP` or providing the `--ip` argument. |
There was a problem hiding this comment.
Ohhhhh I feel like I've wanted this exact command before
There was a problem hiding this comment.
Surprise, it has existed all along!
|
Whoops, merged this in the wrong order. |
3 participants
(staged on top of #608)
humility rpc --ip=... --call ...is almost identical tohumility --ip=... hiffy --call ..., and duplicates the calling implementation. The one exception is being able to execute audprpccall across every compatible SP. I don't think we use that functionality anywhere (searching the wholeoxidecomputerorg finds no users ofhumility rpc), so I'd vote to delete it.This leaves
humility rpc --listenas the only subcommand, which is still useful (and not duplicated elsewhere).