Add optional support for indexmap Map/Set types#77
Merged
Conversation
Contributor
Author
|
Ah it seems I forgot to test without default-features/std. |
Contributor
Author
|
I made the
|
Contributor
Author
|
Ah, finally, the CI is happy :) |
sunshowers
reviewed
May 14, 2026
Comment on lines
+16
to
+17
| let a: IndexSet<_> = [0, 1, 2, 3, 4, 5].into_iter().collect(); | ||
| let b: IndexSet<_> = [3, 4, 5, 6, 7, 8].into_iter().collect(); |
Collaborator
There was a problem hiding this comment.
Just did a small tweak here to avoid using the fully-qualified name. (Not sure if you used an LLM to write this -- that's okay but unnecessarily using fully-qualified names is something Claude in particular is prone to do, and something to watch out for.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional feature
indexmapfor theIndexMapandIndexSettypes.The implementation is mostly just copy&pasted btreemap/hashmap, but as those used the very handy
map_diff/set_diffmacros, the implementation is quite minimal.