Fix time-of-day flake in date range picker e2e test#3269
Merged
Conversation
The "invalid range shows an error" test in instance-metrics.e2e.ts collapsed the default "Last hour" range to a single day by clicking Today twice, then asserted the range was valid. But the calendar keeps the time components from the existing range, and when the test runs shortly after midnight the "Last hour" range straddles midnight (start ~23:00 the previous day, end ~00:00 today). Collapsing both dates to today then leaves the start time after the end time, so the range reads as invalid and the precondition assertion fails. This is what broke CI on main, which ran at 00:03 UTC. Set the start and end times explicitly to a valid same-day order before asserting the range is valid, then flip them to assert the invalid case, so the test no longer depends on the time of day it runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017LT16CnNXBGhBHKk82cq9Z
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "invalid range shows an error" test in instance-metrics.e2e.ts
collapsed the default "Last hour" range to a single day by clicking
Today twice, then asserted the range was valid. But the calendar keeps
the time components from the existing range, and when the test runs
shortly after midnight the "Last hour" range straddles midnight (start
~23:00 the previous day, end ~00:00 today). Collapsing both dates to
today then leaves the start time after the end time, so the range reads
as invalid and the precondition assertion fails. This is what broke CI
on main, which ran at 00:03 UTC.
Set the start and end times explicitly to a valid same-day order before
asserting the range is valid, then flip them to assert the invalid case,
so the test no longer depends on the time of day it runs.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017LT16CnNXBGhBHKk82cq9Z