You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks good, only thing to change might be having the message on default IP pool reflect the type of the pool, since you can have a default for each IP version. "default IPv4 pool for silo" etc. In theory we could also say "unicast" but since you can have a default each for unicast and multicast too, but it's borderline.
Also the checkbox should be tested in a playwright test.
Looks good, only thing to change might be having the message on default IP pool reflect the type of the pool, since you can have a default for each IP version. "default IPv4 pool for silo" etc. In theory we could also say "unicast" but since you can have a default each for unicast and multicast too, but it's borderline.
Also the checkbox should be tested in a playwright test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a checkbox to the IP pool and subnet pool linking modals to make the pool the default pool for the silo.
Closes https://github.com/oxidecomputer/customer-support/issues/413.
Amp-Thread: https://ampcode.com/threads/T-019f1129-f325-73e9-96da-94a8a24fa617