Fix firewall rule test flake in Firefox#3059
Merged
david-crespo merged 4 commits intomainfrom Feb 8, 2026
Merged
Conversation
fix firewall rule flake in firefox
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
BAHAHAHAHA no of course I didn't run the tests locally in Safari. 
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 8, 2026
oxidecomputer/console@bf5d6ef...64a717d * [64a717df](oxidecomputer/console@64a717df) oxidecomputer/console#3060 * [336c4850](oxidecomputer/console@336c4850) oxidecomputer/console#3059 * [5ea92ccd](oxidecomputer/console@5ea92ccd) oxidecomputer/console#3058 * [7e3ca93e](oxidecomputer/console@7e3ca93e) oxidecomputer/console#3056
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 8, 2026
oxidecomputer/console@bf5d6ef...64a717d * [64a717df](oxidecomputer/console@64a717df) oxidecomputer/console#3060 * [336c4850](oxidecomputer/console@336c4850) oxidecomputer/console#3059 * [5ea92ccd](oxidecomputer/console@5ea92ccd) oxidecomputer/console#3058 * [7e3ca93e](oxidecomputer/console@7e3ca93e) oxidecomputer/console#3056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View https://github.com/oxidecomputer/console/pull/3059/changes?w=1 with whitespace changes hidden — there's an indentation change that makes a 5 line change look like 150.
Got Claude on this oldy but goody and I think we really got somewhere. I was able to repro the flake pretty consistently with
--repeat-each 30(it would fail once or twice) and then confirm that that stopped happening with this fix in place. When manually testing an initial version of the fix, I found a key behavior that it is useful to e2e test, so I added that test, and was able to confirm both manually and automatically that the solution here doesn't have this problem. I also improved the comments around theonEnterhandler modified here to explain how it works overall and why this particular approach is necessary to avoid the flake.