Skip to content

Update instance-create to handle both v4 and v6 ephemeral IP options #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charliepark wants to merge 6 commits into
base: main
Choose a base branch
from
+446 −291
Open

Update instance-create to handle both v4 and v6 ephemeral IP options #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cbbf37
Update instance-create to handle both v4 and v6 ephemeral IP options
charliepark Feb 6, 2026
acd97a4
Update copy; smarter handling of compatible defaults
charliepark Feb 7, 2026
badd541
refactor/bugfix
charliepark Feb 7, 2026
b1cbf12
remove useEffects
charliepark Feb 7, 2026
b10cf36
A bit more logic around custom NICs
charliepark Feb 7, 2026
5600704
fix text
charliepark Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components/form/fields/IpPoolSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ type IpPoolSelectorProps<
/** Compatible IP versions based on network interface type */
compatibleVersions?: IpVersion[]
required?: boolean
hideOptionalTag?: boolean
}

export function IpPoolSelector<
Expand All @@ -67,6 +68,7 @@ export function IpPoolSelector<
disabled = false,
compatibleVersions = ALL_IP_VERSIONS,
required = true,
hideOptionalTag = false,
}: IpPoolSelectorProps<TFieldValues, TName>) {
// Note: pools are already filtered by poolType before being passed to this component
const sortedPools = useMemo(() => {
Expand All @@ -90,6 +92,7 @@ export function IpPoolSelector<
placeholder="Select a pool"
required={required}
disabled={disabled}
hideOptionalTag={hideOptionalTag}
/>
</div>
)
Expand Down
Loading
Loading