Skip to content

AB#117049 Switch to Spring Boot method of setting SameSite #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buckett merged 1 commit into from
Apr 29, 2026
Merged

AB#117049 Switch to Spring Boot method of setting SameSite #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/main/java/uk/ac/ox/ctl/ltiauth/TomcatConfiguration.java
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,5 @@ management.endpoints.web.exposure.include=health,sentry
# disable by default
spring.cloud.aws.secretsmanager.enabled=false

# This is needed for the OAuth flow so that the cookie is sent in cross-origin requests.
server.servlet.session.cookie.same-site=None
Comment on lines +66 to +67
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SameSite=None cookies are ignored/rejected by modern browsers unless they also have the Secure attribute. This property is set in the base application.properties, but server.servlet.session.cookie.secure=true is only configured in application-aws.properties, so the comment about cross-origin OAuth may not hold for non-aws profiles (e.g. docker/local) and could break the flow in those environments. Consider scoping same-site=None to the same profiles where cookie.secure (and HTTPS / forwarded-proto handling) are guaranteed, or explicitly document/enforce the Secure requirement for all deployments that rely on cross-site cookies.

Suggested change
# This is needed for the OAuth flow so that the cookie is sent in cross-origin requests.
server.servlet.session.cookie.same-site=None
# Default to a browser-compatible setting for non-HTTPS/local profiles.
# Profiles that require cross-origin OAuth must override this to `None` and also set
# `server.servlet.session.cookie.secure=true` so modern browsers will accept the cookie.
server.servlet.session.cookie.same-site=Lax

Copilot uses AI. Check for mistakes.
Loading