fix(security): upgrade vendored JS libs to patched versions#551
Draft
DeepDiver1975 wants to merge 1 commit into
Draft
fix(security): upgrade vendored JS libs to patched versions#551DeepDiver1975 wants to merge 1 commit into
DeepDiver1975 wants to merge 1 commit into
Conversation
Resolve Trivy HIGH/CRITICAL findings in the vendored AngularJS-era frontend libraries that ship in the ownCloud server Docker image: - underscore 1.7.0 -> 1.13.8 (CVE-2021-23358 critical, CVE-2026-27601 high) - angular 1.4.14 -> 1.8.3 (CVE-2019-10768 high) - prism 1.0.1 -> 1.30.0 (CVE-2021-23341, CVE-2021-32723 high) angular-route and angular-mocks are bumped to 1.8.3 to match angular. Regenerated js/vendor via bower, then trimmed each dir back to the repo's curated runtime file set. In particular this removes the package-lock.json / composer.json manifests that bower pulled in for underscore and prism, which are themselves Trivy scan targets and were never tracked before. App code uses no underscore or deprecated AngularJS APIs directly, and restangular only calls stable underscore methods; the karma suite (22 tests) and gulp production build both pass unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
approved these changes
Jul 23, 2026
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
The various bower.json and package.json diffs look reasonable.
I guess that we just have to believe that the 700+ files touched here are the correct code pulled in from the versions mentioned.
DeepDiver1975
marked this pull request as draft
July 23, 2026 13:25
Member
Author
|
currently shows white screen of death 💀 |
Contributor
|
The Notes app v2.1.2 bundled in the ownCloud Classic 11.0.0 RC2 tarball is working Ok. There are no automated acceptance tests for this app, so green CI doesn't guarantee that it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Trivy
HIGH/CRITICALfindings flagged againstowncloud/notesdeps in the server Docker CI scan. All 5 findings are in the committed, bower-vendored JS libraries underjs/vendor/(AngularJS-era frontend), which ship in the server image.underscoreangular(+angular-route,angular-mocks)prismApproach
js/bower.jsonand regeneratedjs/vendor/via bower.bower updatedragged in build-artifact noise including new scannable manifests that were never tracked before —underscore/package-lock.json(1073 pkgs),prism/package-lock.json,prism/composer.json. Those are themselves Trivy scan targets that could reintroduce findings from dev/build deps, so they've been removed. No lockfiles or composer manifests remain injs/vendor.Why this is low-risk despite the major-version jumps
js/app/,js/config/) uses nounderscorecalls and no deprecated AngularJS APIs (.success/.error,$cookieStore, etc.) directly.restangularonly calls stable underscore methods (_.each,_.extend,_.contains,_.isUndefined, …) that are unchanged through 1.13.prismis used bymdEditfor note syntax highlighting;angularis the app framework.Test plan
npm test(karma / gulp) — 22/22 pass, unchanged from baselinegulp build(concat + uglify →public/app.min.js) succeeds🤖 Generated with Claude Code