Skip to content

build(deps-dev): bump sinon from 17.0.2 to 22.1.0#690

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/sinon-22.0.0
Open

build(deps-dev): bump sinon from 17.0.2 to 22.1.0#690
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/sinon-22.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 6, 2026

Copy link
Copy Markdown
Contributor

Bumps sinon from 17.0.2 to 22.1.0.

Changelog

Sourced from sinon's changelog.

22.1.0

  • d36e921b fix: let returns override returnsArg (王胜)

    Signed-off-by: 王胜 2318857637@qq.com

  • 40c4caa0 fix: align restoreObject docs test with idempotent behavior (#2745) (Julia Miller)

    restoreObject was made idempotent in #2737 — it no longer throws for objects with no restorable methods. Updates the docs page and its corresponding test to reflect this.

  • a68dac19 fix: throw a clear error when throwArg index equals the argument count (#2743) (spokodev)
    • fix: throw a clear error when throwArg index equals the argument count

    spyCall.throwArg(pos) guarded with pos > this.args.length, so calling it with pos equal to the number of recorded arguments slipped past the guard and reached throw this.args[pos], throwing undefined instead of the intended TypeError. A thrown undefined cannot be inspected as an Error and is reported by test frameworks as no exception thrown.

    Use >= to match ensureArgs in behavior.js and the sibling callArg helpers, which already reject an out-of-range index with a clear error.

  • 9ea504e3 feat: make sinon.restoreObject idempotent (#2737) (Ilia Choly)

    Passing an object with no live fakes to restoreObject now restores nothing instead of throwing, giving it symmetry with sinon.restore() and sandbox.restore(). The strict "found no methods" check is retained for spy(object) and stub(object), which now use a dedicated walkObjectStrict export, while restoreObject uses the loose walkObject. Passing a falsy value still throws.

    Fixes #2736

  • 4db4feff fix: preserve fake undefined argument validation (Vishal Kumar Singh)
  • 755a40d7 fix: isolate callId counter per sandbox for parallel test support (Vishal Kumar Singh)

    The global callId counter in proxy-invoke.js caused calledImmediatelyBefore and calledImmediatelyAfter to fail when tests run in parallel with separate sandboxes. Each sandbox now maintains its own callId counter, passed through the spy/stub/fake creation chain via a context object.

    Fixes #2472

Released by Morgan Roderick on 2026-07-20.

22.0.0

... (truncated)

Commits
  • ab289e9 22.1.0
  • bb3b75a chore: remove Jekyll steps from version hook
  • bb38f25 chore: run docs tests in preversion hook
  • d36e921 fix: let returns override returnsArg
  • 11db213 ci: run docs tests on every PR (#2746)
  • 40c4caa fix: align restoreObject docs test with idempotent behavior (#2745)
  • 5ccb7fd build(deps): bump the action-deps group with 4 updates (#2744)
  • a68dac1 fix: throw a clear error when throwArg index equals the argument count (#2743)
  • 9ea504e feat: make sinon.restoreObject idempotent (#2737)
  • cf5d9e8 fix: remove dead link and exclude code example URLs from link check
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by mrgnrdrck, a new releaser for sinon since your current version.


@dependabot dependabot Bot added dependencies javascript Pull requests that update Javascript code labels May 6, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/sinon-22.0.0 branch from 9f04b49 to aab3964 Compare May 12, 2026 23:19
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/sinon-22.0.0 branch 2 times, most recently from b82e3d0 to 23d95bf Compare May 20, 2026 23:19
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/sinon-22.0.0 branch from 23d95bf to b4d7c39 Compare May 28, 2026 10:50

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Security: no findings (sinon 17.0.2 → 22.0.0, test devDependency)
  • Stability: JS Unit check fails on the head commit; PHP unit/style/lint/semantic-commit all pass. Sinon 17→22 is a large major-version jump likely to change mocking/faketimer APIs, consistent with the JS Unit failure.
  • Performance: no findings
  • Test coverage: n/a
  • TODOs found: 0
  • Dependency touched: yes — sinon (BSD-3-Clause), major bump
  • CI status: failing (JS Unit)

Verdict

Not mergeable as-is — JS Unit is red. Not approving; likely needs test-code updates to match the new Sinon API, not just a version bump.

🤖 Automated review by Claude Code (security · stability · performance · coverage)


Generated by Claude Code

@DeepDiver1975

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/sinon-22.0.0 branch from b4d7c39 to 615c6a8 Compare July 13, 2026 10:58
@dependabot
dependabot Bot requested a review from a team as a code owner July 13, 2026 10:58
@DeepDiver1975

Copy link
Copy Markdown
Member

Holding: CI is failing (not a rebase conflict). Failing check(s): JS Unit / Javascript Unit. A rebase won't fix this — needs a human/upstream fix.

@DeepDiver1975

Copy link
Copy Markdown
Member

@dependabot rebase

Bumps [sinon](https://github.com/sinonjs/sinon) from 17.0.2 to 22.1.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/CHANGES.md)
- [Commits](sinonjs/sinon@v17.0.2...v22.1.0)

---
updated-dependencies:
- dependency-name: sinon
  dependency-version: 22.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title build(deps-dev): bump sinon from 17.0.2 to 22.0.0 build(deps-dev): bump sinon from 17.0.2 to 22.1.0 Jul 21, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/sinon-22.0.0 branch from 615c6a8 to 5bee75c Compare July 21, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants