[TECHNICAL] Resource leak in CopyAndUploadContentUrisTask #4806
Open
dataCenter430 wants to merge 2 commits intoowncloud:masterfrom
Open
[TECHNICAL] Resource leak in CopyAndUploadContentUrisTask #4806dataCenter430 wants to merge 2 commits intoowncloud:masterfrom
dataCenter430 wants to merge 2 commits intoowncloud:masterfrom
Conversation
d1b1561 to
bcfe14e
Compare
Contributor
Author
|
Hi, @joragua |
Collaborator
|
Thanks for your contribution @dataCenter430! 💯 I'll check this PR as soon as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…UrisTask
Related Issues
Fixes #4797
Summary
Fixes a resource leak in
CopyAndUploadContentUrisTaskreported in #4797.Problem
In the loop over URIs (lines 147–182),
inputStreamandoutputStreamwere reassigned every iteration but never closed inside the loop. Only the last iteration’s streams were closed in the outerfinallyblock, so all previous streams were leaked (file descriptors and memory).Solution
InputStreamandFileOutputStream.inputStream/outputStreamvariables and the stream-closing logic from the outerfinallyblock.Each URI’s streams are now closed at the end of that iteration (normal or exceptional), so no streams are leaked.