[FEATURE REQUEST] Add margin in members list for long display names

[rohan-jadhav-dev]

Fixes #4781

Summary

Fixes lack of right margin in the members list when display name is long.

Changes

• Added layout_marginEnd to the container LinearLayout to prevent overflow
• ellipsize stays as middle for consistency with the rest of the app

Testing

• Tested with long display name "Jose Rodriguez Perez Martinez Lopez Garcia"
• Verified name truncates properly with "..." in the middle
• Verified with Can view role (no edit/delete buttons)
• Verified with Can edit role

[CLAassistant]

All committers have signed the CLA.

[jesmrec]

Thanks for the contribution @rohan-jadhav-dev. I'll give you some tips that you will also find in our CONTRIBUTING file:

• For the branch names, we use underscore to separate _ the chunks, like fix/spaces_member_name_margin_4781 . Also, the prefix to use should match the type of the issue. The issue you fixed starts with [FEATURE REQUEST], so, it should be feature/... Don't worry for that in the current PR, but please take in account for future contributions 😉

• For the PR title, we use to add a prefix like [FIX], [BUG], [FEATURE REQUEST]... at the beginning. Check examples in the PR list

• We use to follow Conventional Commits to name the commits. As you'd have realised, the CI checks below ⬇️ shows a red ❌ in the Conventional Commits check. For a quick summary check this. Basically, the commit name must start with a correct prefix (check here the ones that CI verifies). Please fix, you can amend the commit or fix it with an interactive rebase. Any question you could have about this processes just ping us and we will be pleasant to help you!! This is required to merge the PR.

• In terms of CHANGELOG, every PR should contain changelog entry to briefly describe the work you did. You'll find how to do it in this link. In the changelog/ folder you'll find multiple examples (check unreleased folder for the newest ones). Also, in the list of closed PRs you will see the changelog file in every PR.

Any question about the process, @joragua or myself will be happy to help you!!

[jesmrec]

About your solution for the given problem:

The ellipsize property should stay in the middle, since this way is implemented around the app. For consistency, every ellipsized string should be displayed in the same way everywhere in the app. The fix should be focused in the container's margin or padding properties and not in the text itself.

As you checked with and without the pencil and trashbin icons, it will be checked in QA-phase after the code review and the green CI.

Thanks a lot again!!

[rohan-jadhav-dev]

Hi @jesmrec 👋

Thank you for the detailed feedback!

I have noted all your points for future contributions.

Could you please let me know:

1. Is my current fix (adding layout_marginEnd) the right approach?
2. Should I also add the CHANGELOG entry now?

I am ready to make any changes needed to get this merged.
Thank you for your patience! 🙏

[jesmrec]

Thanks for taking care @rohan-jadhav-dev!!

Is my current fix (adding layout_marginEnd) the right approach?

I'd say yes, but, it's a question for @joragua!

Should I also add the CHANGELOG entry now?

I noticed you already created the changelog/unreleased/4781 . An automatic process will take care of adding the content to the CHANGELOG file, don't worry. You just have to add the changelog entry as you did.

A couple of improvements about your entry:

• Let one blank line between sections
• Use the Present perfect passive tense to describe

As a suggestion/example:

Bugfix: Add margin in members list for long display names in all cases

An extra margin has been added to the right side in the list of members when the display name is long, preventing the text to overflow. 

https://github.com/owncloud/android/issues/4781 
https://github.com/owncloud/android/pull/4800 

Fell free to modify the description and title, but please keep the consistency with all files inside 😄 . Thanks a lot!!!

[jesmrec]

Sorry, i forgot to mention a couple of details about the changelog entry:

• Please, add a line break at the end of the file.
• The commit that adds the entry is marked as fix: . It's not a fix, but a chore:
• The name of the file is the PR id (not the issue id)

[rohan-jadhav-dev]

Hi @jesmrec @joraqua 👋

Thank you for the detailed feedback and guidance!

I have addressed all the requested changes:

• ✅ Renamed changelog file from 4781 → 4800 (PR id)
• ✅ Added a line break at the end of the changelog file
• ✅ Changed the changelog commit from fix: to chore:

The PR is ready for your review whenever you get the chance. I really appreciate your patience and support! 🙏

[joragua]

Nice job @rohan-jadhav-dev! 💯 Somme comments here

1. Since this is not a fix (the issue is marked with [FEATURE REQUEST] label), I'd use feat: prefix for the first commit instead of fix:

2. We use to have only one commit for changelog in a PR, so you can remove both commits with an interactive rebase and push the final version using chore: prefix (like this: chore: add changelog file)

3. We also avoid merging master into the current branch without rebasing. So, if the current branch is out of date, we rebase it only after the PR is validated by QA. You can remove the commit Merge branch 'master' into fix/spaces-member-name-margin-4781 and wait until the final steps to update the branch.

Let us know if you have any questions about git commands and we'll help you! 😄

[joragua]

Missing blank line at the end of the file

[joragua]

Why did you change the configuration (layout_width andlayout_marginEnd) of member_name and member_role elements? What would happen if the user has expiration date? 🤔