Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Jan 13, 2026

Related Issues

App: #4613

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan:

Reports:

@joragua joragua self-assigned this Jan 13, 2026
@joragua joragua force-pushed the feature/search_and_show_new_space_members branch from 7299fa1 to 27030d9 Compare January 14, 2026 11:37
@joragua joragua force-pushed the feature/search_and_show_new_space_members branch from c1041e3 to 7db90f9 Compare January 14, 2026 12:52
@joragua joragua force-pushed the feature/search_and_show_new_space_members branch from 3339374 to 809857b Compare January 20, 2026 08:35
@joragua joragua marked this pull request as ready for review January 20, 2026 11:49
@joragua joragua requested a review from jesmrec January 20, 2026 11:49
@joragua joragua force-pushed the feature/search_and_show_new_space_members branch from 0994368 to 0f38db8 Compare January 21, 2026 09:35
@joragua joragua force-pushed the feature/search_and_show_new_space_members branch from 4c1b022 to c3afb33 Compare January 21, 2026 09:47
@joragua joragua requested a review from jesmrec January 21, 2026 10:09
Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, let's QA this

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 21, 2026

(1)

Typing characters does not refresh screen with results. App should be unfocused and focused to list:

Screenrecorder-2026-01-21-13-31-54-142.mp4

NOTE: not in every server... crazy

Xiaomi Redmi Note 13, Android 15
Galaxy Tab A4, Android 15

c534e2ba4

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 21, 2026

(2) [FIXED]

In search view, add some special characters like ? or $

Current:

Snackbar Unknown error

I realised the query parameter is $search: use$

Expected:

No error, just no results in case there are no matches. Checking iOS, the query parameter is enclosed in quotation marks (if it helps):

$search: "User$"

Xiaomi Redmi Note 13, Android 15
Galaxy Tab A4, Android 15

c534e2ba4

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 21, 2026

(3)

In case the typed chars don't match with any user, it'd be a good idea to show a message like No matches or No user or group matches your search (iOS approach) No users or groups found (web approach)

Xiaomi Redmi Note 13, Android 15
Galaxy Tab A4, Android 15

c534e2ba4

@joragua
Copy link
Collaborator Author

joragua commented Jan 21, 2026

I think that (1) and (2) are fixed now @jesmrec 🙌🏻

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 21, 2026

(4) (improvement)

Given a high number of results, the lag for showing the results is perceptible. Could it be posible to add a spinner, so the view does not seem to be frozen. Ideally (it might not be feasible), the spinner would replace the ✖️ while the operation is executed.

Xiaomi Redmi Note 13, Android 15
Galaxy Tab A4, Android 15

ff47f47767

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 21, 2026

(2) fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add a member to a space: Search user and show the list of matches

3 participants