Closed
Conversation
Collaborator
|
Thanks for the fix. In the code review, take in account this: owncloud/android-library#379 (comment) |
Contributor
|
Hi @hannesa2, this solution does not fix the problem completely. Yes, we can build the app now, but it crashes when we try to share the logs. Could you take a look? Thanks! |
Collaborator
|
@hannesa2 could you update this PR together with owncloud/android-library#379 (or this branch, more recent: https://github.com/owncloud/android-library/tree/optionalLiveLogging) The idea is checking this asap over our newest Thanks a lot in advance |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a proposal to fix conflicting provider form logging lib owncloud/android-library#379
It simply accept the provider from ownCloud