test: bump phpstan to v2#1263
Draft
phil-davis wants to merge 1 commit into
Draft
Conversation
PHPstan is updated from v1 to v2. v2 is the current version supported on PHP 8. The format of ignored errors in phpstan.neon is changed to use the new rawMessage format. Previously the messages had to be encoded as regex strings. For oridnary text messages, the rawMessage form is much simpler. Some ignored messages were moved into the code as phpstan-ignore comment lines. This associates the ignored message directly with the exact place in the code that generates the message. That will be helpful if/when code refactoring is being done to "fix" the code that generates the phpstan message. The PHP unit tests were emitting some PHP deprecation messages. Code has been minimally refactored to avoid these. Signed-off-by: Phillip Davis <phil@jankaritech.com>
phil-davis
commented
Jul 23, 2026
Comment on lines
+84
to
+88
| if ($batchCount > 0) { | ||
| $this->sendBatch($users, $output); | ||
| if ($progress !== null) { | ||
| $progress->advance($batchCount); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
phpstan reported that $batchCount was always greater than 0 when evaluated at the while below.
That was true, because the (only) way out of this loop was the early break above.
I have refactored this loop so that while ($batchCount > 0) is actually the place where the decision to exit the loop is made.
phil-davis
commented
Jul 23, 2026
|
|
||
| /** @var string */ | ||
| protected $user; | ||
| protected $user = ''; |
Contributor
Author
There was a problem hiding this comment.
There were potential ways to access $user when it was still null.
It is supposed to be a string, so set it to the empty string at instantiation.
(Some day we could really declare all the types, and enable strict_types, etc.)
phil-davis
commented
Jul 23, 2026
| */ | ||
| protected function parseCollections($message) { | ||
| // @phpstan-ignore nullCoalesce.variable | ||
| $message = $message ?? ''; |
Contributor
Author
There was a problem hiding this comment.
The unit tests managed to call down to here with $message null.
That reported:
PHPUnit 9.6.35 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.32
Configuration: ./phpunit.xml
Warning: No code coverage driver available
............................................................... 63 / 398 ( 15%)
............................................................... 126 / 398 ( 31%)
............................................................... 189 / 398 ( 47%)
............................................................... 252 / 398 ( 63%)
............................................................... 315 / 398 ( 79%)
......PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/phil/git/owncloud/core/apps-external/activity/lib/PlainTextParser.php on line 56
PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/phil/git/owncloud/core/apps-external/activity/lib/PlainTextParser.php on line 56
PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/phil/git/owncloud/core/apps-external/activity/lib/PlainTextParser.php on line 56
PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/phil/git/owncloud/core/apps-external/activity/lib/PlainTextParser.php on line 56
......................................................... 378 / 398 ( 94%)
.................... 398 / 398 (100%)
Time: 00:03.787, Memory: 40.00 MB
OK (398 tests, 1213 assertions)
$message is supposed to be a string. But we don't explicitly declare that.
So if it is passed as null, then set it to the empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPstan is updated from v1 to v2. v2 is the current version supported on PHP 8.
The format of ignored errors in phpstan.neon is changed to use the new rawMessage format. Previously the messages had to be encoded as regex strings. For oridnary text messages, the rawMessage form is much simpler.
Some ignored messages were moved into the code as phpstan-ignore comment lines. This associates the ignored message directly with the exact place in the code that generates the message. That will be helpful if/when code refactoring is being done to "fix" the code that generates the phpstan message.
The PHP unit tests were emitting some PHP deprecation messages. Code has been minimally refactored to avoid these.
There are no real production run-time fixes to make here. The purpose of this PR is to demonstrate the type of minimal changes that can be needed when updating from PHPstan v1 to v2. No rush to review or merge this.