fix: heap buffer overflow in acmp pm#3545
Open
airween wants to merge 1 commit intoowasp-modsecurity:v2/masterfrom
Open
fix: heap buffer overflow in acmp pm#3545airween wants to merge 1 commit intoowasp-modsecurity:v2/masterfrom
airween wants to merge 1 commit intoowasp-modsecurity:v2/masterfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a potential heap buffer overflow in the ACMP (Aho–Corasick) pattern insertion path by ensuring allocations and copies respect the provided pattern length rather than relying on C-string semantics.
Changes:
- Fix prefix buffer allocation for trie nodes to allocate based on the current depth (
i) rather thanstrlen(pattern). - Fix full-pattern storage to allocate and copy using the explicit
length(viamemcpy+ terminator) instead ofstrlen/strcpy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
This PR fixes a possible heap buffer overflow in ACMP (Aho Corasick) pattern matching function.
why
See #3544 for details - same changes for v2.