Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the following issue with the Helm chart:
If deploying the default chart to a local cluster, the static UI will have an env var set that points to localhost:8083/api for all api requests. This is not exposed by default though, nor is it the correct url when deploying with the ingress enabled. The effect is that the UI frontend loads and is accessible, but all api requests fail due to not being reachable
changes to a conditional api url, dropping the port in case of deploying with the ingress.
Discussion: An alternative approach would be to simply add the correct
metaflowUIBackendURL: "http://localhost/api/"to the example values.yaml. This would also document the necessity of providing a value for it.