fix: stream SQL database dumps#206
Open
Treasure520520 wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

/claim #59
Summary
This is a focused streaming slice for the large database dump issue.
Instead of building the entire SQL dump in a single in-memory string/blob,
/export/dumpnow returns aReadableStreamand writes the dump incrementally:LIMIT ? OFFSET ?pagesINSERTstatements as it is producedNULL, booleans, bigint, and binary valuesThis does not attempt to solve the full async/R2 continuation path in one PR. It removes the immediate O(database dump size) string allocation while keeping the existing endpoint behavior intact, so it can compose with later R2/alarm work.
Validation
./node_modules/.bin/prettier --check src/export/dump.ts src/export/dump.test.ts./node_modules/.bin/vitest run src/export/dump.test.ts(6 tests)git diff --checkThe repo-wide
./node_modules/.bin/tsc --noEmitis still blocked by pre-existing type errors outside this PR (src/do.ts,src/operation.ts, existing tests). The focused dump tests and formatting checks pass.