fix: stream and async R2 database dumps#202
Open
akamabu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #59
Summary
Fixes #59 by moving database dumps away from building the entire dump in memory and adding an R2-backed asynchronous export path for large databases.
What changed
/export/dumpnow returns aReadableStreaminstead of assembling a single giant string/blob in memory.LIMIT/OFFSETpages (EXPORT_CHUNK_SIZEconfigurable, default 500).INSERTstatements.GET /export/dump?async=trueEXPORT_BUCKETR2 binding.dump_YYYYMMDD-HHMMSSZ.sqlto R2 by default.filename=query parameter.callbackUrl=orEXPORT_CALLBACK_URL.ctx.waitUntilwhen available so the request can return202 Acceptedwhile R2 upload continues.EXPORT_BUCKET,EXPORT_CALLBACK_URL, andEXPORT_CHUNK_SIZE.Testing
npx vitest run src/export/dump.test.ts✅npx vitest runwas also run; the new dump tests pass, while 4 pre-existing unrelated RLS tests fail insrc/rls/index.test.ts.