AO3-7576 Fix comment emails for news posts posted from preview - #5982
Open
marcus8448 wants to merge 2 commits into
Open
AO3-7576 Fix comment emails for news posts posted from preview#5982marcus8448 wants to merge 2 commits into
marcus8448 wants to merge 2 commits into
Conversation
github-actions
Bot
added
Scope: Tests Only
marcus8448
removed
the
Scope: Tests Only
Collaborator
|
The code looks good at a glance, but I'm not sure it goes far enough. It looks like it still allows for admin posts to be created without an Should we also either make posts invalid without an Or if that's not the case, can we have a test showing the emails are sent even if no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7576
Purpose
Fixes comment notifications to the news post email not getting sent when the news post was posted from preview.
Changes the
admin_idof an admin post in a model callback instead of the hidden field in the form.Credit
marcus8448 (he/him)