AO3-6806 Fix first comment layout on short admin posts#5834
Open
noahbravo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)?Issue
https://otwarchive.atlassian.net/browse/AO3-6806
Purpose
Fixes a layout issue where the first comment on a short admin post had an oversized byline and a misplaced icon when the comment form was not present.
Root cause:
clear: both. When an admin post is shorter than the sidebar, the first comment'sclear: bothcatches the active sidebar float and forces the comment to expand until the float clears.Changes made:
clear: nonerule under .news.admin.homein15-group-comments.cssto prevent comment pseudo-elements from interacting with the sidebar float. Only affects admin post views. Works and chapters are unaffected.slideDown()/slideUp()withshow()/hide()on admin posts inshow_comments.js.erbandhide_comments.js.erb. The slide animation creates a temporary BFC that triggers a layout reflow on completion, which was hidden before the CSS fix but became noticeable after. Works and chapters are unaffected.Testing Instructions
Follow the reproduction steps in AO3-6806:
https://otwarchive.atlassian.net/browse/AO3-6806
Expected behavior:
Automated tests:
Credit
Name: Noah Bravo
Pronouns: they/them