AO3-3934 Footer not sitting at bottom of page#5827
Open
forceofcalm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-3934
Purpose
The footer does not sit at the bottom of the page on pages where the site content does not fill the full height. This is especially obvious on larger screens and pages with short content like /about.
Fixing this was not easily, if at all, possible with only CSS2. To remedy this, we use minimal CSS3 flexbox rules that should not affect the current views in older browsers without CSS3, while fixing the issue in all browsers that do support CSS3. Unfortunately, because this is entirely a cosmetic change and due to the limitations in CSS2, this may be the best solution we have, though I am open to any and all suggestions.
This change also supports other device layouts and is mobile-responsive.
Testing Instructions
I've tested this change as thoroughly as I could for regressions, but there may be pages or edge cases I am unaware of that could be affected. If this CSS3 approach is accepted, I can update the Jira ticket.
Credit
calm (they/them)