AO3-6142 Make prompt meme claims show back up after deleting fill...#5709
Open
techlingyi wants to merge 4 commits intootwcode:masterfrom
Open
AO3-6142 Make prompt meme claims show back up after deleting fill...#5709techlingyi wants to merge 4 commits intootwcode:masterfrom
techlingyi wants to merge 4 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...on the user's Claims page and the Post New Work form
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6142
Purpose
Copies the work model's after_destroy method for challenge assignments so it also destroys the work's challenge claims after the user deletes the work. This makes the claim reappear as unfulfilled on the user's claims page and reappear as an option in the Post New Work form.
Notes
Ran into issues when trying to manually test posting two fills to one claim under the same username and then deleting one of them. After posting both fills, both the prompts page and user's claims page show only one fill, which then disappears upon deletion; the second fill doesn't show up afterwards. I think this falls under the scope of https://otwarchive.atlassian.net/browse/AO3-2407 - deleting one fill functions as expected when the two fills are from different usernames.
Credit
Ling-Yi (any pronouns)