Skip to content

AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noahbravo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter #5699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7ef5f
AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter
noahbravo Apr 4, 2026
90cc40c
AO3-7160 Apply review feedback for form dl.index positioning
noahbravo Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/challenge_assignments/_maintainer_index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<%= render "maintainer_index_fulfilled" %>
<% else %>
<%= form_tag update_multiple_collection_assignments_path(@collection), method: :put do %>
<fieldset>
<fieldset class="maintainer-assignments">
Comment thread
noahbravo marked this conversation as resolved.
Outdated

<% if !(params[:pinch_hit] || params[:unfulfilled] || params[:fulfilled]) %>
<%= render "maintainer_index_defaulted" %>
Expand Down
6 changes: 6 additions & 0 deletions public/stylesheets/site/2.0/07-interactions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ form li ul.autocomplete li.input {
margin-top: 0 !important;
}

/* Pinch hitter autocomplete dropdown must escape the assignments container.
Core form styles set fieldset/dl to overflow: hidden, which clips it. */
form fieldset.maintainer-assignments, form fieldset.maintainer-assignments dl.index {
overflow: visible;
Comment thread
noahbravo marked this conversation as resolved.
Outdated
}

.autocomplete li.added, .post .meta dd ul li.added {
display: inline-block;
}
Expand Down
Loading