AO3-7366 AO3-7367 Fix browser title on user skins pages#5696
AO3-7366 AO3-7367 Fix browser title on user skins pages#56960111-0222 wants to merge 7 commits intootwcode:masterfrom
Conversation
|
Hi, 0111-0222! Thank you so much for this pull request. Someone will be along to review it soon. I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
|
Hi there I've emailed in with my Jira email & user! :) |
…-fix-skins-page-title # Conflicts: # features/other_a/page_title.feature
dc44d6f to
4a90b21
Compare
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7366
https://otwarchive.atlassian.net/browse/AO3-7367
Purpose
The browser page title for a user's skins pages showed "Skins | Archive of Our Own" regardless of skin type. It now shows "username - Work Skins | Archive of Our Own" or "username - Site Skins | Archive of Our Own" as intended.
Testing Instructions
Credit
0111-0222 (he/him)