Skip to content

AO3-7331 Adding username to the title of the Marked for Later page #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarken merged 4 commits into from
Apr 28, 2026
+3 −3
Merged

AO3-7331 Adding username to the title of the Marked for Later page #5689

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afd5a3a
AO3-7331 Adding username to the title of the Marked for Later page
Respheal Apr 2, 2026
71291ab
AO3-7331 Fixed uninitialized variable
Respheal Apr 2, 2026
287e193
AO3-7331 addressing feedback by updating feature test and reducing ch…
Respheal Apr 3, 2026
c5f8e56
AO3-7331 Fixed the logged-in reader for the Marked for Later test
Respheal Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/controllers/readings_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ def load_user

def index
@readings = @user.readings.visible
@page_subtitle = t(".history_page_title", username: @user.login)
if params[:show] == 'to-read'
@readings = @readings.where(toread: true)
@page_subtitle = t(".marked_for_later_page_title")
@page_subtitle = t(".marked_for_later_page_title", username: @user.login)
else
Comment thread
Respheal marked this conversation as resolved.
Outdated
@page_subtitle = t(".history_page_title", username: @user.login)
end
@readings = @readings.order("last_viewed DESC").includes(work: :pseuds)
@pagy, @readings = pagy(@readings)
Expand Down
2 changes: 1 addition & 1 deletion config/locales/controllers/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ en:
success: Your history is now cleared.
index:
history_page_title: "%{username} - History"
marked_for_later_page_title: Marked for Later
marked_for_later_page_title: "%{username} - Marked for Later"
related_works:
index:
page_title: "%{login} - Related Works"
Expand Down
Loading