Skip to content

AO3-7182 Hide restricted works from guests on prompts page#5685

Open
luis-pabon-tf wants to merge 6 commits intootwcode:masterfrom
luis-pabon-tf:AO3-7182
Open

AO3-7182 Hide restricted works from guests on prompts page#5685
luis-pabon-tf wants to merge 6 commits intootwcode:masterfrom
luis-pabon-tf:AO3-7182

Conversation

@luis-pabon-tf
Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7182

Purpose

Fixes a visibility bug on the meme prompt page.

Credit

Luis Pabon (they/he)

Copy link
Copy Markdown
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Luis -- it's great to see you again!

Thank you for working on this, and I'm sorry we didn't see your comment on the issue asking for clarification about the intended behavior. We'd like the existence of these restricted works completely hidden from guests, the same way we hide restricted works on, e.g., tag work pages.

What that means is:

  1. If the only fills for a prompt are restricted, the "Fulfilled By" listbox should not be displayed.
  2. If there are both public and restricted fills for a prompt, the "Fulfilled By" listbox should be present, but only list the public works.

If you could make that change, we'd appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants