Open
Conversation
Signed-off-by: Thomas Steenbergen <opensource@steenbe.nl>
tsteenbe
force-pushed
the
python-batch-1
branch
from
e010ab5 to
b66d375
Compare
Align older curations with new way of doing declared license curations. Improvements include: - More elaborate proof for curations - No URLs pointing to main or master branches Signed-off-by: Thomas Steenbergen <opensource@steenbe.nl>
tsteenbe
force-pushed
the
python-batch-1
branch
from
b66d375 to
6ee52da
Compare
Comment on lines
+21
to
+24
| "Apache Software License": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain" | ||
| "BSD License": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain" | ||
| "BSD, Public Domain, Apache": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain" | ||
| "Public Domain": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain" |
Member
There was a problem hiding this comment.
I think these mappings shouldn't include the compound expression. ORT should be able to handle that.
Member
There was a problem hiding this comment.
@tsteenbe, do you intend to continue working on this PR?
Contributor
|
@tsteenbe @MarcelBochtler Hello dear peeps, this is a kind reminder on this PR. We have a couple of projects failing due to PyPI packaging and it would be really great if we can reuse ort-config directly, instead of forking on our side. |
Member
|
@tsteenbe, how do we proceed with this? |
sschuberth
requested changes
Nov 12, 2025
Member
sschuberth
left a comment
sschuberth
left a comment
There was a problem hiding this comment.
I definitely think there's value in this PR, but we should reorganize the commits for easier review.
| https://github.com/encode/starlette/blob/0.31.0/pyproject.toml#L20. | ||
| declared_license_mapping: | ||
| "BSD License": "BSD-3-Clause" | ||
| "BSD License": "BSD-2-Clause" |
Member
There was a problem hiding this comment.
I believe this change of the mapping is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.