Skip to content

fix: prevent expense name truncation in group expense list #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ziesie1 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Open

fix: prevent expense name truncation in group expense list #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/components/Expense/ExpenseList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,13 @@ const Expense: ExpenseComponent = ({ e, userId }) => {

return (
<>
<div className="flex items-center gap-4">
<div className="inline-block w-6 text-center text-xs text-gray-500">
<div className="flex min-w-0 items-center gap-4">
<div className="inline-block w-6 shrink-0 text-center text-xs text-gray-500">
{toUIDate(e.expenseDate)}
</div>
<CategoryIcon category={e.category} className="size-5 shrink-0 text-gray-400" />
<div>
<p className="max-w-[180px] truncate text-sm lg:max-w-md lg:text-base">{e.name}</p>
<div className="min-w-0 pe-1">
<p className="truncate text-sm lg:text-base">{e.name}</p>
<p className="xs:max-w-full flex max-w-32 truncate text-center text-xs text-gray-500">
{displayName(e.paidByUser, userId)}{' '}
{t(`ui.expense.user.${e.amount < 0n ? 'received' : 'paid'}`)} {toUIString(e.amount)}
Expand Down Expand Up @@ -178,13 +178,13 @@ const CurrencyConversion: ExpenseComponent = ({ e, userId }) => {
const userDetails = api.user.getUserDetails.useQuery({ userId: receiverId! });

return (
<div className="flex items-center gap-4">
<div className="inline-block w-6 text-center text-xs text-gray-500">
<div className="flex min-w-0 items-center gap-4">
<div className="inline-block w-6 shrink-0 text-center text-xs text-gray-500">
{toUIDate(e.expenseDate)}
</div>
<CurrencyConversionIcon className="size-5 shrink-0 text-gray-400" />
<div>
<p className="max-w-[180px] truncate text-sm lg:max-w-md lg:text-base">
<div className="min-w-0">
<p className="truncate text-sm lg:text-base">
{getCurrencyHelpersCached(e.currency).toUIString(e.amount)} ➡️{' '}
{
/* @ts-ignore */
Expand Down