Conversation
docs/guides/rate-limits-project.mdx
Outdated
|
|
||
| - **Burst limit**: Maximum requests per second (rps), allowing for short traffic spikes. | ||
| - **Sustained limit**: Maximum requests per minute (rpm), ensuring consistent performance over time. | ||
|
|
There was a problem hiding this comment.
Should we split the technical below into another document? It feels odd to get into the "how" when we are explaining the why above.
There was a problem hiding this comment.
I think if we split it, they won't see/read it... the above is 'what' project rate limits are and below is 'how' they need to implement them
Update bucket naming 'threshold' definitions to match new definitions
|
Hey Una, Here's the banner text, along with a proposal for a small restructuring that I think makes the overall navigation cleaner. Proposed structure Three pages:
The key benefit: since New visitors coming via search will also land on the overview first, which means everyone gets context on old vs. new before diving into the details. The banners on the detail pages are then a secondary safety net for anyone who arrives there directly. Banner text for
Banner text for
Both banners: One open item on the parent page: I included a note that customers can check which system applies to them in the Ory Console under Settings → Rate Limits. That's just an idea for now — would actually be quite simple to implement and a nice touch, but it's not there yet. I've marked it as a placeholder so we can either build it or drop the reference before publishing. Let me know if the restructuring works for you! |
…allout to top of files
|
Hey @unatasha8 @wassimoo, I reviewed all five pages in the preview and want to propose restructuring the pages under Problem with the current sub-pages Proposed structure What moves to the parent page The parent page would cover: which system applies, migration plan, endpoint-based protection (volumetric + inflight tables), HTTP headers, and 429 handling. Everything shared lives there. What stays on the child pages
This way, each page has a clear job: parent = shared behavior, legacy = old thresholds, new = new concepts, reference = new thresholds. Other items I noticed across the pages:
I setup a call later on to discuss this proposal. |
|
Following up on the call with @unatasha8 we agreed on the general structure: One change to the proposal: shared concepts (endpoint-based protection, HTTP headers, 429 handling, backoff) should not move to the parent page. Instead, keep them on both rate-limits-legacy and rate-limits-new so each page is self-contained. Why: When we retire the legacy system, we want a clean cutover — just remove rate-limits and rate-limits-legacy, then promote rate-limits-new to rate-limits. If shared content lives on the parent page, that move becomes a content migration. If each child page is self-contained, it's just a rename. The parent page (rate-limits) becomes a lightweight routing page, which includes the system that applies to you, the migration timeline, and links to the appropriate child page. Everything else from the original proposal (collapsing rate-limits-project + rate-limits-endpoint into a single rate-limits-new concepts page, and a separate reference page for thresholds) still stands. |
|
@tricky42 Not following your comments... The top level 'rate-limits' only contains info about whether the legacy or new rate limits apply to the user. Below are the rate-limits-legacy and rate-limits-new files. Both contain the shared concepts: HTTP headers, 429 handling, backoff etc. with new also explaining new buckets. Legacy does contain project and endpoint content, where as New is broken down into to pages: project & endpoint. This is a better devision of the contain for find ability, SEO, etc. When legacy is removed, we still just need to remove the top level and the legacy files. Then New becomes rate-limits. |
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments