feat: add support for listing owner message automation#322
Open
MatrixNeoKozak wants to merge 1 commit into
Open
feat: add support for listing owner message automation#322MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
orangecoding
requested changes
Jun 4, 2026
Owner
orangecoding
left a comment
orangecoding
left a comment
There was a problem hiding this comment.
There is a lot of changes due to changing the jsdoc. Would you mind reverting this? I don't know what pyrefly is, but it seems wrong
|
|
||
| /** | ||
| * @param {import('fastify').FastifyInstance} fastify | ||
| * @pyrefly_bundled_typeshed_082e1b761623/lib2to3/fixes/fix_tuple_params.pyi {import('fastify').FastifyInstance} fastify |
| /** @import { SpecFilter, SpatialFilter } from './types/filter.js' */ | ||
| /** @import { SimilarityCache } from './types/similarityCache.js' */ | ||
| /** @import { Browser } from './types/browser.js' */ | ||
| /** @pyrefly_bundled_typeshed_082e1b761623/zipimport.pyi { ParsedListing } from './types/listing.js' */ |
Owner
There was a problem hiding this comment.
Maybe I'm not up to date, but this seems wrong:
yrefly_bundled_typeshed_082e1b761623/zipimport.pyi
Owner
|
@MatrixNeoKozak Hey,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the foundation for automatically sending messages to listing owners. It updates the Job configuration to include message templates and a mode toggle, and introduces a placeholder method in the pipeline executioner to support future implementation of the actual sending logic per provider.
Summary of Changes
messageTemplateandautoSendMessagefields to the Job configuration inlib/api/routes/jobRouter.jsto allow users to define automated messages._sendToOwnermethod inlib/FredyPipelineExecutioner.jsas a hook for the new feature.lib/types/job.jsto reflect the new job configuration fields.Rationale
This prepares Fredy for the requested feature, enabling users to configure automated messaging to listing owners. The implementation is currently a placeholder, allowing further work to implement provider-specific message sending mechanisms.
Technical Impact