Skip to content

feat: add the JSON schema for the default Macaron buildspec#1314

Merged
behnazh-w merged 2 commits intomainfrom
behnazh/add-buildspec-json-schema
Feb 24, 2026
Merged

feat: add the JSON schema for the default Macaron buildspec#1314
behnazh-w merged 2 commits intomainfrom
behnazh/add-buildspec-json-schema

Conversation

@behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Feb 24, 2026

Summary

This PR adds a JSON schema for the buildspec output and also adds a corresponding validation step for integration tests.

Description of changes

  • Add the schema to the src/macaron/resources/schemas directory.
  • Update the the documentation
  • Add a validation step in integration tests and adjust the corresponding TypedDict for the buildspec.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 24, 2026
@behnazh-w behnazh-w requested a review from nicallen February 24, 2026 01:13
@behnazh-w behnazh-w changed the title feat: add the JSON schema for the default Macaron buispec feat: add the JSON schema for the default Macaron buidspec Feb 24, 2026
@behnazh-w behnazh-w changed the title feat: add the JSON schema for the default Macaron buidspec feat: add the JSON schema for the default Macaron buildspec Feb 24, 2026
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w force-pushed the behnazh/add-buildspec-json-schema branch from 3ad8b40 to 1b6e613 Compare February 24, 2026 01:24
@nicallen
Copy link
Member

I notice that there is already one there, but I don't think our own schemas should be under src/macaron/resources/schemastore. That directory name is a reference to https://github.com/SchemaStore/schemastore specifically, for the schema file that we download from there (at build time in the Makefile), along with its LICENSE file as required by their license. Putting our own schemas in that same directory would suggest that those files are also under their license, which isn't our intention. Create a different directory for our own schemas (this new one and move the one that is already there), I suggest src/macaron/resources/schemas.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w
Copy link
Member Author

I notice that there is already one there, but I don't think our own schemas should be under src/macaron/resources/schemastore. That directory name is a reference to https://github.com/SchemaStore/schemastore specifically, for the schema file that we download from there (at build time in the Makefile), along with its LICENSE file as required by their license. Putting our own schemas in that same directory would suggest that those files are also under their license, which isn't our intention. Create a different directory for our own schemas (this new one and move the one that is already there), I suggest src/macaron/resources/schemas.

Fixed in 006db30.

@behnazh-w behnazh-w merged commit cfa73c1 into main Feb 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants