Skip to content

[GR-73555] Fix PGenerator assertion. #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 2 commits into from
Mar 4, 2026
Merged

[GR-73555] Fix PGenerator assertion. #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53fb370
Fix PGenerator#handleResult assertion
DSouzaM Feb 24, 2026
efa868d
Remove unnecessary SuppressWarnings
DSouzaM Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...racle.graal.python/src/com/oracle/graal/python/builtins/objects/generator/PGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public BytecodeDSLState(PBytecodeDSLRootNode rootNode, Object[] arguments, Conti
}

public Object handleResult(PGenerator generator, ContinuationResult result) {
assert result.getContinuationRootNode() == null || result.getContinuationRootNode().getFrameDescriptor() == generator.frame.getFrameDescriptor();
assert PBytecodeDSLRootNode.cast(result.getContinuationRootNode()).getFrameDescriptor() == generator.frame.getFrameDescriptor();
isStarted = true;
// We must keep the previous root so that we can load its BytecodeNode to resolve BCI to
// location, the next continuation node may have different BytecodeNode
Expand Down
2 changes: 0 additions & 2 deletions ...cle.graal.python/src/com/oracle/graal/python/nodes/bytecode_dsl/PBytecodeDSLRootNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,6 @@ public static Object doOther(Object ex) {
* provides access to the generator frame even before the generator was started.
*/
@Yield
@SuppressWarnings("truffle-interpreted-performance") // blocked by GR-69979
public static final class YieldGenerator {
@Specialization
public static Object doYield(
Expand Down Expand Up @@ -1199,7 +1198,6 @@ public static Object doObject(Object value,
* Performs some clean-up steps before suspending execution, and updates the generator state.
*/
@Yield
@SuppressWarnings("truffle-interpreted-performance") // blocked by GR-69979
public static final class YieldValue {
@Specialization
public static Object doObject(Object value,
Expand Down
Loading