[Feature] Adding support for oci-genai-auth-python.#1
Conversation
Signed-off-by: Varun Shenoy <varun.vinayak.shenoy@oracle.com>
OpheliaLjh
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left a few inline comments covering some potential bugs, config inconsistencies, and minor cleanup items. Nothing blocking, happy to discuss any of them.
OpheliaLjh
left a comment
There was a problem hiding this comment.
Thank you for the changes!
OpheliaLjh
left a comment
There was a problem hiding this comment.
Thanks for providing the fixes and addressing the comments, I left some some small comments
OpheliaLjh
left a comment
There was a problem hiding this comment.
LGTM, left some nit comments
| from oci_genai_auth import OciSessionAuth | ||
|
|
||
| client = OpenAI( | ||
| base_url="https://inference.generativeai.us-chicago-1.oci.oraclecloud.com/v1", |
There was a problem hiding this comment.
Let's use "https://inference.generativeai.us-chicago-1.oci.oraclecloud.com/20231130/actions/v1" here.
"https://inference.generativeai.us-chicago-1.oci.oraclecloud.com/v1" should not even exist for partner api and let's not promote it further in docs
|
|
||
| ## Running the Examples | ||
|
|
||
| 1. Update `examples/agenthub/openai/common.py` and/or `examples/partner/openai/common.py` with your `COMPARTMENT_ID`, `PROJECT_OCID`, and set the correct `REGION`. |
There was a problem hiding this comment.
Create respective README.md in examples/agenthub/README.md and examples/partner/openai/README.md
|
|
||
| ## Using AgentHub APIs (non-passthrough) | ||
|
|
||
| AgentHub runs in non-pass-through mode and provides a unified interface for interacting with models and agentic capabilities. |
There was a problem hiding this comment.
I can provide an updated verison here
Description
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: