[FSSDK-12933] Refactor message generator to use TS compiler API#1170
Merged
Conversation
Replace the dynamic-import-based message_generator.ts with a static TS-parser approach (scripts/generate-messages.js) that preserves declaration order and eliminates the jiti runtime dependency. Add a test script and CI job for the generator. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
raju-opti
force-pushed
the
raju/msgen-refactor
branch
from
July 21, 2026 14:06
6967e76 to
1da4773
Compare
|
coverage: 77.725%. remained the same — raju/msgen-refactor into master |
junaed-optimizely
approved these changes
Jul 21, 2026
junaed-optimizely
left a comment
junaed-optimizely
left a comment
Contributor
There was a problem hiding this comment.
Approved with one minor concern!
| @@ -0,0 +1,121 @@ | |||
| #!/usr/bin/env node | |||
Contributor
There was a problem hiding this comment.
#! is UNIX only! Not that it matters a lot but build:win could potentially be broken for this.
Contributor
Author
There was a problem hiding this comment.
Yeah. But other scripts are also using this currently. Windows build is relevant only for devs' local machine, but we can use wsl nowadays. We can come back and fix the windows build later if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the dynamic-import-based message_generator.ts with a static TS-parser approach (scripts/generate-messages.js) that preserves declaration order and eliminates the jiti runtime dependency. Add a test script and CI job for the generator.
Test plan
Issues