[AI-FSSDK] [FSSDK-12670] Block ODP identify event for single identifier#1152
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
raju-opti
requested changes
Jun 1, 2026
| // Identify requires 2+ identifiers to link (e.g., vuid + fs_user_id). | ||
| // A single identifier has no cross-reference value and generates unnecessary traffic. | ||
| if (identifiers.size < 2) { | ||
| this.logger.log(LogLevel.Debug, 'ODP identify event is not dispatched (fewer than 2 valid identifiers).'); |
Contributor
There was a problem hiding this comment.
this is not a supported interface. Should use this.logger.debug(msg) instead
Contributor
There was a problem hiding this comment.
also, logger can be undefined. should use this.logger?.debug
|
coverage: 77.713% (-0.05%) from 77.761% — ai/jaeopt/FSSDK-12670-odp-event into master |
raju-opti
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ODP identify event to only send when multiple valid identifiers exist. Previously, the SDK sent an identify event even with a single identifier (just fs_user_id or just vuid), which provides no identity-linking value and generates unnecessary network traffic.
Changes
DefaultOdpManager.identifyUserto skip event dispatch when fewer than 2 valid identifiers are presentJira Ticket
FSSDK-12670
Notes