chore(deps-dev): bump vitest from 4.1.7 to 4.1.8#1367
Conversation
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.7 to 4.1.8. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 4.1.8 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryThis PR bumps
Confidence Score: 5/5Safe to merge — a dev-only dependency patch bump with a single comment clarification. Both changes are low-risk: the lockfile update is a straightforward patch bump with no API surface changes, and the test file change is a one-line comment fix that makes the error-handling intent more accurate without altering any logic. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[fs.rmSync with maxRetries:10] -->|success| B[Temp dir cleaned up]
A -->|throws error| C{Check error code}
C -->|EBUSY or EPERM| D[Swallow — Windows WAL lock]
C -->|Other error| E[Re-throw — quota, corruption, etc.]
Reviews (2): Last reviewed commit: "fix(test): clarify EPERM comment — remov..." | Re-trigger Greptile |
| // Only swallow EBUSY / EPERM — Windows WAL locks that outlast the retry budget. | ||
| // Any other error (permission denied, quota, path corruption) surfaces normally. |
There was a problem hiding this comment.
The second line of the comment says "Any other error (permission denied, quota, path corruption) surfaces normally", but
EPERM is the POSIX code for "Operation not permitted" — it covers both the Windows WAL-lock scenario and genuine permission-denied failures. The comment's promise that "permission denied surfaces normally" isn't kept for EPERM. Clarifying the second line removes this contradiction.
| // Only swallow EBUSY / EPERM — Windows WAL locks that outlast the retry budget. | |
| // Any other error (permission denied, quota, path corruption) surfaces normally. | |
| // Only swallow EBUSY / EPERM — Windows WAL locks that outlast the retry budget. | |
| // Any other error (quota, path corruption, unexpected OS error) surfaces normally. |
There was a problem hiding this comment.
Fixed. Removed the contradictory 'permission denied' from the second comment line. The updated comment now reads: 'Any other error (quota, path corruption, unexpected OS error) surfaces normally.' — which accurately reflects that EPERM is swallowed along with EBUSY as a Windows WAL-lock workaround.
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Bumps vitest from 4.1.7 to 4.1.8.
Release notes
Sourced from vitest's releases.
Commits
e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)