Skip to content

chore(deps-dev): bump vitest from 4.1.7 to 4.1.8#1367

Merged
carlos-alm merged 7 commits into
mainfrom
dependabot/npm_and_yarn/vitest-4.1.8
Jun 8, 2026
Merged

chore(deps-dev): bump vitest from 4.1.7 to 4.1.8#1367
carlos-alm merged 7 commits into
mainfrom
dependabot/npm_and_yarn/vitest-4.1.8

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 6, 2026

Copy link
Copy Markdown
Contributor

Bumps vitest from 4.1.7 to 4.1.8.

Release notes

Sourced from vitest's releases.

v4.1.8

   🐞 Bug Fixes

    View changes on GitHub
Commits
  • e61f2dd chore: release v4.1.8
  • e4067b3 fix(browser): disable client cdp API when allowWrite/allowExec: false [ba...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 4.1.8
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 6, 2026
@carlos-alm

Copy link
Copy Markdown
Contributor

@greptileai

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps vitest from 4.1.7 to 4.1.8 (a patch release fixing browser CDP and orphaned Playwright-route bugs) and addresses a follow-up from a prior review by correcting a misleading comment in the embedding regression teardown.

  • package-lock.json: All @vitest/* sub-packages bumped consistently to 4.1.8; no dependency graph changes beyond the version increment.
  • tests/search/embedding-regression.test.ts: Comment updated to remove "permission denied" from the list of errors that surface normally, accurately reflecting that EPERM is silently swallowed alongside EBUSY as a Windows WAL-lock workaround.

Confidence Score: 5/5

Safe to merge — a dev-only dependency patch bump with a single comment clarification.

Both changes are low-risk: the lockfile update is a straightforward patch bump with no API surface changes, and the test file change is a one-line comment fix that makes the error-handling intent more accurate without altering any logic.

No files require special attention.

Important Files Changed

Filename Overview
package-lock.json Routine patch bump of vitest and all @vitest/* sub-packages from 4.1.7 to 4.1.8; all hashes and peer-version references updated consistently.
tests/search/embedding-regression.test.ts Comment-only fix: removed the contradictory 'permission denied' from the list of errors that surface normally, since EPERM is already being swallowed as a Windows WAL-lock workaround.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[fs.rmSync with maxRetries:10] -->|success| B[Temp dir cleaned up]
    A -->|throws error| C{Check error code}
    C -->|EBUSY or EPERM| D[Swallow — Windows WAL lock]
    C -->|Other error| E[Re-throw — quota, corruption, etc.]
Loading

Reviews (2): Last reviewed commit: "fix(test): clarify EPERM comment — remov..." | Re-trigger Greptile

Comment on lines +94 to +95
// Only swallow EBUSY / EPERM — Windows WAL locks that outlast the retry budget.
// Any other error (permission denied, quota, path corruption) surfaces normally.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The second line of the comment says "Any other error (permission denied, quota, path corruption) surfaces normally", but EPERM is the POSIX code for "Operation not permitted" — it covers both the Windows WAL-lock scenario and genuine permission-denied failures. The comment's promise that "permission denied surfaces normally" isn't kept for EPERM. Clarifying the second line removes this contradiction.

Suggested change
// Only swallow EBUSY / EPERM — Windows WAL locks that outlast the retry budget.
// Any other error (permission denied, quota, path corruption) surfaces normally.
// Only swallow EBUSY / EPERM — Windows WAL locks that outlast the retry budget.
// Any other error (quota, path corruption, unexpected OS error) surfaces normally.

Fix in Claude Code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Removed the contradictory 'permission denied' from the second comment line. The updated comment now reads: 'Any other error (quota, path corruption, unexpected OS error) surfaces normally.' — which accurately reflects that EPERM is swallowed along with EBUSY as a Windows WAL-lock workaround.

@carlos-alm

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@carlos-alm

Copy link
Copy Markdown
Contributor

@greptileai

@carlos-alm carlos-alm merged commit 732def4 into main Jun 8, 2026
23 checks passed
@carlos-alm carlos-alm deleted the dependabot/npm_and_yarn/vitest-4.1.8 branch June 8, 2026 03:11
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant