Fix dulwich checkout_branch deprecation warning in testing utilities #819
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Integration tests emit deprecation warnings from dulwich 0.22.9:
Goal: eliminate warning by migrating to current dulwich API.
What changed
porcelain.checkout_branch(repo, branch.encode("utf-8"))withporcelain.checkout(repo=repo, target=branch)ininfrahub_sdk/testing/repository.pycheckout()performs identical operation with cleaner signature (handles string/bytes transparently)How to review
Single-line change in
GitRepo.init(). Old API took encoded bytes; new API accepts strings directly.How to test
Run integration test that triggered the warning:
No deprecation warning should appear.
Impact & rollout
Checklist
uv run towncrier create ...)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.