-
Notifications
You must be signed in to change notification settings - Fork 6
Use ternary operator instead of if-else-block
#814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR refactors multiple conditional assignments across the codebase to use single-line ternary expressions instead of multi-line if/else blocks. Changes span eight files including client utilities, CLI commands, GraphQL renderers, node relationships, templates, and test files. Additionally, the SIM108 rule is removed from the Ruff linter's ignore list in 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
9e42f1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d4ef40a.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-sim108.infrahub-sdk-python.pages.dev |
…key` instead of `if`-`else`-block
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #814 +/- ##
====================================================
+ Coverage 80.33% 80.54% +0.21%
====================================================
Files 115 117 +2
Lines 9865 10209 +344
Branches 1504 1538 +34
====================================================
+ Hits 7925 8223 +298
- Misses 1419 1456 +37
- Partials 521 530 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Simplify code with linting fixes.
Summary by CodeRabbit
Refactor
Chores